[Bug 479730] Review Request: perl-DateTimeX-Easy - Parse a date/time string using the best method available

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479730


Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
               Flag|                            |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx>  2009-01-12 22:59:02 EDT ---
- Needs work
+ Ok
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1047456
- rpmlint is NOT silent for SRPM. But silent for RPM.
perl-DateTimeX-Easy.src:25: W: unversioned-explicit-provides
perl(DateTimeX::Easy::DateParse)

+ source files match upstream url
a43d1aeefd0e3cdac3228df0be053713  DateTimeX-Easy-0.085.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=4, Tests=107,  2 wallclock secs ( 0.03 usr  0.01 sys +  1.66 cusr  0.08
csys =  1.78 CPU)

+ Package perl-DateTimeX-Easy-0.085-1.fc11 =>
  Provides: perl(DateTimeX::Easy) = 0.085 perl(DateTimeX::Easy::DateParse)
  Requires: perl(Carp) perl(Date::Parse) perl(DateTime)
perl(DateTime::Format::Flexible) perl(DateTime::Format::Natural)
perl(DateTime::TimeZone) perl(DateTimeX::Easy::DateParse) perl(Scalar::Util)
perl(Time::Zone) perl(base) perl(constant) perl(strict) perl(vars)
perl(warnings)

Suggestions:
1) Fix unversioned-explicit-provides rpmlint message by using
perl(DateTimeX::Easy::DateParse)  = %{version}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]