Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479723 --- Comment #5 from Todd Zullinger <tmz@xxxxxxxxx> 2009-01-12 15:01:13 EDT --- (In reply to comment #3) > The other comment I have from a quick look is that the %define at the top for > the make really probably should just be explicitly in the %build section. True, it could be. I had it there to start, but it causes a spurious warning from rpmlint, which I figured could be easily avoided by defining it outside of %build and %prep. Does that cause any harm? And is it uglier there than the rpmlint warning might be? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review