Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 --- Comment #2 from Xavier Bachelot <xavier@xxxxxxxxxxxx> 2009-01-12 10:04:38 EDT --- (In reply to comment #1) > This is not an official review. > > 1. When applying patch #2, patch returns: > > patch unexpectedly ends in middle of line > I've removed this patch and replaced it with a patch that update to latest trunk. There's only a handful of changes since the last beta. > While this doesn't abort the build, the patch file should be fixed to not > generate this error. > > 2. This would fail to run with SELinux activated. You should fix the context > of the CGI script, per http://fedoraproject.org/wiki/PackagingDrafts/SELinux. > Creating a drraw-selinux subpackage would probably be ideal in this case. > I'm not SELinux proficient, but I'll try to take care of that. Thanks for the pointer. In your opinion, does such a requirement block the review or can we save that for later ? > 3. Patch #2 appears to be a bug fix. If you have filed a bug with the > upstream source, you should reference this in your spec file; if not, you > should file one and reference it. See > http://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment There's no bug tracker for this project. This was reported on their mailing list by a colleague of mine, as well as some patch for new features. Actually, even the svn repository is not public, but after a few mails with upstream, I now have read-only access. I'll post new spec and srpms when the selinux issue is addressed. Thanks for the pre-review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review