Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459535 --- Comment #23 from Christoph Wickert <fedora@xxxxxxxxxxxxxxxxxxxx> 2009-01-11 20:02:48 EDT --- The requirements are still not correct. It often makes sense to use file dependencies, for some deps it is actually needed: /usr/bin/cdrecord and /usr/bin/mkisofs can be provided by different packages but not only by wodim. Also the name of a package might change over time as it did with /usr/bin/logger, so it's better to require the file. This is what I suggest: Requires: /usr/bin/logger Requires: /usr/bin/mkisofs Requires: /usr/bin/cdrecord Requires: bc Requires: bzip2 Requires: coreutils Requires: diffutils Requires: dvd+rw-tools Requires: less Requires: ftp Requires: genisoimage Requires: gettext Requires: gnupg Requires: gzip Requires: openssh-clients Requires: rsync Requires: sed Requires: tar Requires: which I also removed zip, because I doubt someone will use zip archives for backups as they can't store permissions. lzma and dar are also not very common, so I wouldn't add them. I would also remove rsync, but this is your decision. Please replace %{_var}/lib/ with %{_localstatedir} in your spec. Hint: If you want to use a macro like "%{_var}/lib/" in the changelog, you need to escape it as "%%{_var}/lib/", not "_{_var}/lib/" You have added %{_var}/lib/%{name} to the %files list, but you also need to create the dir during install, otherwise it wont get included in the package. Please remove the "It just works." from the description, because we don't want these kind of "advertising" in our packages. Some trivial typos in changelog: Fixe -> Fix No no need for making a new package now, just fix the spec and post the link here. I will look after the patch to get rid of the hardcoded patch in the meantime. Stay tuned. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review