Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477338 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? --- Comment #4 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> 2009-01-11 02:52:35 EDT --- REVIEW: + rpmlint (see comment) php-pecl-imagick.i386: I: checking php-pecl-imagick.i386: E: zero-length /usr/share/doc/php-pecl-imagick-2.2.1/INSTALL php-pecl-imagick.i386: E: zero-length /usr/share/doc/php-pecl-imagick-2.2.1/TODO php-pecl-imagick.src: I: checking php-pecl-imagick-debuginfo.i386: I: checking 3 packages and 0 specfiles checked; 2 errors, 0 warnings. + package name ok + specfile name ok + license Ok (PHP) + spec in english + source ok c205ff5e38ca88aad01e74ea8d0e3816 imagick-2.2.1.tgz + source URL ok + latest stable version + build ok (i386, x86_64, ppc and ppc64) + build ok in mock (F9, F10, devel) + BR ok for fedora + no locale + own all directories ok + perm ok + clean ok + contain code ok + doc small enough + doc not required to run + no devel + no gui + install start with rm buildroot + Final Requires /bin/sh /usr/bin/pecl config(php-pecl-imagick) = 2.2.1-2.fc11 libMagickCore.so.1 libMagickWand.so.1 libc.so.6 php(api) = 20041225 php(zend-abi) = 20060613 - Final Provides not ok (see MUST) config(php-pecl-imagick) = 2.2.1-2.fc11 imagick.so php-pecl-imagick = 2.2.1-2.fc11 + package.xml is V2 (registration ok) SHOULD: - TODO is provided empty by upstream, so i think it's ok (could be not empty in another version) - INSTALL is also empty but generally provides information about "building from source" which is not usefull with RPM. You should probably remove it (some package keep it, some remove it) - add version in BR (ok for all fedora but EPEL 4 don't have requirement) BuildRequires: php-devel >= 5.1.3, php-pear, ImageMagick-devel >= 6.2.4 - setup the -n option is needless when -c used - add conditional (recommended in PHP Guidelines) %post => %if 0%{?pecl_install:1} %postun => %if 0%{?pecl_uninstall:1} Without, you package couldn't be imported in EPEL-5 (macro not defined in old php-pear, but even "pecl install" don't work => no extension registration in this case) MUST: - add the missing virtual provides (from PHP guidelines) Provides: php-pecl(%peclName) Only the "MUST" must be fixed for approval, but SHOULD need your attention. Do you want to maintain thi package in EPEL ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review