[Bug 459535] Review Request: backup-manager - A command line backup tool for GNU/Linux

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459535





--- Comment #16 from Christoph Wickert <fedora@xxxxxxxxxxxxxxxxxxxx>  2009-01-10 14:20:55 EDT ---
(In reply to comment #15)
> Yes I did. You can choose not to believe me of course.

The review guidlines include the packaging guidelines and at least the latter
are not met.

> Here's the output of rpmlint here :
> backup-manager.noarch: W: incoherent-version-in-changelog 0.7.7-3
> ['0.7.7-3.fc10', '0.7.7-3.fc10']
> Which is completely useless.

You are supposed to run rpmlint on _all_packages, not only the binaries.

$ rpmlint /home/chris/Desktop/backup-manager-0.7.7-3.fc10.src.rpm 
backup-manager.src: W: strange-permission backup-manager-0.7.7.tar.gz 0770
backup-manager.src: W: strange-permission backup-manager.spec 0770
backup-manager.src: W: strange-permission backup-manager.cron.daily 0770
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

Hint: You should also run rpmlint on the installed package, because some errors
are not detected otherwise.

> It's nice however that you found out about the binary dependencies.

This is IMO also part of the review guidelines.

P.S.: I know I am pedantic ;)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]