[Bug 459535] Review Request: backup-manager - A command line backup tool for GNU/Linux

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459535


Christoph Wickert <fedora@xxxxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora@xxxxxxxxxxxxxxxxxxxx
               Flag|fedora-review+              |fedora-review?




--- Comment #10 from Christoph Wickert <fedora@xxxxxxxxxxxxxxxxxxxx>  2009-01-10 09:22:32 EDT ---
This package does not meet the packaging guidelines and therefore I'm resetting
the fedora‑review flag:

Summary: is not good. 

License tag is wrong. The package is GPLv2+, not GPL. Please take a look at the
headers of the scripts.

Not all docs are included, THANKS is missing. Credits are important, just like
licenses and should therefore be included.

Some requirements are missing. There are a couple of commands in the scripts
that are not included in Requires:, see
http://fedoraproject.org/wiki/Packaging/Guidelines#File_Dependencies

Changelog format is not correct: Changelogs get parsed automatically and
therefor there should be a blank line between all entries. Also you should not
add a comment line in %changelog, see
http://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

Timestamp ot Source= does not match, see
https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

0.7.7 is a development version. Is this supposed to be included in a stable
Fedora release?


Aurelien, please review more carefully next time. I would like to at least see
a list of the tests you have done on this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]