Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476440 --- Comment #7 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2009-01-10 08:44:23 EDT --- Sorry, I've been away for a while. Now I'm back and we can finish up this beast. Here are a few more issues to address. * Please add the changes you made to the changelog in the future with the correct date(s). It'll be easier to see what is actually changed. That's why we keep a changelog. * Also please switch to %defattr(-,root,root,-) * We should preserve the timestamps of all the relevant files we package in the %install section. By relevant files, I mean the non-compiled files. * Please remove the commented-out line(s) that are unnecessary. Also, in the comments and in the changelog section, we use %% for macros instead of a single %, so that the macros don't expand out during package building. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review