Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478388 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx --- Comment #1 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2009-01-09 04:58:00 EDT --- Just some quick comment on your spec file - '%prep rm -rf $RPM_BUILD_ROOT' looks a bit unusual. - Please use %defattr(-,root,root,-) instead of %defattr(-,root,root) - '--vendor fedora' is no longer needed see https://fedoraproject.org/wiki/TomCallaway/DesktopFileVendor - Is 'Requires: qt4' necessary? I guess that rpm will pick this up automatically. - You should preserve the time stamps - cp -p ... - make install ..... INSTALL="install -p" https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review