Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478846 --- Comment #1 from Lubomir Rintel <lkundrak@xxxxx> 2009-01-08 10:58:28 EDT --- Created an attachment (id=328474) --> (https://bugzilla.redhat.com/attachment.cgi?id=328474) Fix the std{in,out,err} openness test Much better than initial package; thanks for the patches! Upstream may be interested in them as well! 1.) Useless requires Requires: cracklib Requires: gpgme Requires: cdk Requires: dotconf Requires: ncurses Requires: libxml2 >= 2.6.16 Requires: zlib All these are useless please remove them. They appropriate dependnecies are generated automatically. 2.) You don't use optflags. Marek! What a shame! The culprit is CFLAGS= that you pass to %configure which uses its CFLAGS=. Please change it to CPPFLAGS! Once FORTIFY_SOURCE is in effect it will reveal that you use open() incorrectly. I attached a fix. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review