Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479230 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx --- Comment #1 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2009-01-08 07:41:03 EDT --- Just some comment on your spec file Preserving the time stamps in the %install section would be nice. make install DESTDIR=%{buildroot} INSTALL="install -p" if possible Shouldn't the URL better be http://code.google.com/p/pidgin-privacy-please/ and Source0: http://pidgin-privacy-please.googlecode.com/files/pidgin-privacy-please-0.5.2.tar.gz than pointing to freshmeat? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review