Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474149 --- Comment #5 from Conrad Meyer <konrad@xxxxxxxxxx> 2009-01-07 15:09:49 EDT --- Some more comments: - Should this be System Environment/Libraries (and not Development/Libraries)? - Line 46 of the spec has a tab instead of spaces. - Line 61 should be %{cmake} . (sets everything automatically). - Line 72, the mode should be 755 not 644. Rpm only strips 755 files when looking for debuginfo, this is why you are getting the warnings about unstripped binaries. - Line 88, you should use %{_libdir} instead of /usr/lib - Line 93, this should be "%{_includedir}/chipmunk" not "%{_includedir}/chipmunk/*.h" (the latter leaves an unowned directory). - Line 87, should be "...*.so.*" (as opposed to "...*.so*"). This is because un-suffixed .so files belong in the -devel package. - Add %{_libdir}/*.so to %files devel. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review