Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: db4o https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201551 ------- Additional Comments From rpm@xxxxxxxxxxxxxx 2006-08-07 19:16 EST ------- Here's a formal review: MUST items OK: * package meets naming guidelines * source files match upstream $ md5sum db4o-5.5-mono.tar.gz 4aea1da3b96a2b92c9ac69ee2ccb9a63 db4o-5.5-mono.tar.gz * specfile is properly named, is cleanly written and uses macros consistently * dist tag is present * build root is correct * license field matches the actual license * license is open source-compatible * latest version is being packaged * BuildRequires are proper * rpmlint errors can be ignored $ rpmlint -i db4o-5.5-1.x86_64.rpm E: db4o no-binary The package should be of the noarch architecture because it doesn't contain any binaries. E: db4o only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. * final provides are sane mono(Db4oMonoTest) = 0.0.0.0 mono(Db4oTools) = 0.0.0.0 mono(db4o) = 5.5.1.0 db4o = 5.5-1 * no traditional shared libraries are present * package is not relocatable * owns the directories it creates * doesn't own any directories it shouldn't * no duplicates in %files * file permissions are appropriate * %clean is present * %check is not present * no scriptlets present * code, not content * %docs are not necessary for the proper functioning of the package * no headers * no pkgconfig files * no libtool .la droppings * no locales * not a GUI app * not a web app MUST items BAD: * package doesn't meet packaging guidelines - {_prefix}/%{_lib} vs. %{_libdir}, See http://fedoraproject.org/wiki/Packaging/Mono#head-ae42c4b5de20e082855e2f5151542730ef40f15b http://fedoraproject.org/wiki/Packaging/Mono#head-932fb76878e1f34706c9962336a5f23fcc277af2 - installs shipped precompiled binaries, See http://fedoraproject.org/wiki/Packaging/Mono#head-1d3454f431ec1c8761eb46582e7f66bbddc1fd08 * source URL returns 404 $ wget http://www.db4o.com/community/db4o-5.5-mono.tar.gz --00:31:44-- http://www.db4o.com/community/db4o-5.5-mono.tar.gz => `db4o-5.5-mono.tar.gz' Resolving www.db4o.com... 213.203.204.172 Connecting to www.db4o.com|213.203.204.172|:80... connected. HTTP request sent, awaiting response... 404 Not Found 00:31:44 ERROR 404: Not Found. * final requires contain duplicates mono(Db4oTools) = 0.0.0.0 mono(System) = 1.0.5000.0 mono(db4o) = 5.5.1.0 mono(mscorlib) = 1.0.5000.0 mono-core i.e. mono(System) and mono(mscorlib) are provided by mono-core * documentation takes up 75% of the installed size, -docs subpackage is necessary SHOULD items: * License text included in package (License text not included upstream) Also, I don't like the use of sed where tr -d would suffice. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review