Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477190 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #5 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 2009-01-06 14:03:36 EDT --- = Review = Good: - rpmlint checks return nothing - package meets naming guidelines - package meets packaging guidelines - license (GPLv3+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent (well, 99%) - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file One very minor item, you're using "${RPM_BUILD_ROOT}" and "$RPM_BUILD_ROOT" in the spec. Pick one and use it consistently. You can make this change before you commit to CVS. APPROVED. I will sponsor you. Please follow the process here: https://fedoraproject.org/wiki/PackageMaintainers/Join#Get_Sponsored -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review