Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476720 Nicolas Mailhot <nicolas.mailhot@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |needinfo?(sanjay_ankur@yaho | |o.co.in) --- Comment #5 from Nicolas Mailhot <nicolas.mailhot@xxxxxxxxxxx> 2009-01-04 12:51:16 EDT --- Looks nice so here is a complete review: 1. probably better to use %define archivename %{fontname}-%{version} 2. The summary needs a little work (for example 'Geometric sans-serif font inspired by Futura') 3. you do not need to add "sfd" to the name, renaming is only a requirement for OFL fonts, GPL does not require it 4. beteckna.se seems dead, no need to reference it in the description 5. we already have a licensing field, do not include "The font is free, licensed under terms of the GNU GPL" in the description 6. You're wrapping your description lines too short, Fedora standard is 79 columns not 50 7. do package AUTHORS LICENSE CHANGELOG as %doc too 8. I see beteckna is actually 3 different font families: Beteckna, BetecknaLowerCase, Beteckna Small Caps. Please package them in 3 different subpackages using the -multi template (the two families which do not have a correct uppercase/lowercase mix are probably more "fantasy" than "sans-serif" fonts anyway) 9.[not a blocker] Please ask upstream to consider adding the FSF Font exception to their licensing so the font can be used by people who embed fonts in PDF files 10. Please change the category of the wiki page describing the font so other packagers see they need not work on it http://fedoraproject.org/wiki/Beteckna_fonts (see the help in http://fedoraproject.org/wiki/Font_description_template ) You do not need a packager sponsorship for this, just a Fedora FAS account Anyway that's all mostly small stuff and nothing that should be too hard for you to fix. ⇒ NEEDINFO in the meanwhile -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review