Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463912 Lubomir Rintel <lkundrak@xxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from Lubomir Rintel <lkundrak@xxxxx> 2009-01-04 07:35:44 EDT --- 1.) Why do you throw away the valgrind run results? make %{?_smp_mflags} valgrind || true 2.) This can be replaced %dir %{_datadir}/%{name} %{_datadir}/%{name}/* with %{_datadir}/%{name} and this pushd %{buildroot}%{_datadir}/%{name}/ ln -s ../../../%{_sysconfdir}/%{name}/config.xml config.xml popd with ln -s ../../../%{_sysconfdir}/%{name}/config.xml %{buildroot}%{_datadir}/%{name}/config.xml Sorry -- I could not resist these; just because I found nothing severe ;) None of these is anything that would block the review: APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review