Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472098 Jon Stanley <jonstanley@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonstanley@xxxxxxxxx --- Comment #6 from Jon Stanley <jonstanley@xxxxxxxxx> 2009-01-03 22:22:56 EDT --- A few issues with this package (I haven't done a full review of it yet, these are just some things that stick out): I have no idea where or how to get this exact source. If this is an svn snapshot (which from the version looks like it is), you'll want to include instructions in the spec file on how to obtain this exact version - i.e. something like 'svn export -r1234 http://svn.example.com/svn/example example ; tar -czvf example.tar.gz example/' or whatever). You'll also want to version the package per the guidance found at https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages rpmlint complains about the summary not starting with a capital letter, pretty simple to fix. The changelog is not in a proper format. You have: %changelog * Mon Dec 29 2008 MindTouch <services@xxxxxxxxxxxxx> - 8.08.12159 nightly built Which should be: * Mon Dec 29 2008 MindTocuh <services@xxxxxxxxxxxxx> - 0.08.12159 - Nightly built or something similar. Refer to https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs fore more info (It looks like you're using the third format sort of, but I've never seen anyone use that in practice and was kind of surprised to see it in the guidelines). In %post, you're adding users - please see https://fedoraproject.org/wiki/Packaging:UsersAndGroups for guidance on doing this. Similarly, according to the guidelines, we don't want to delete the user for the reasons stated. You're also installing content into /var/www - according to the guidelines, this should be instead in /usr/share/dekiwiki - see https://fedoraproject.org/wiki/Packaging:Guidelines#Web_Applications for more details. I also noticed that your logfile is %ghost'ed - I wouldn't do that (but I don't think there's a guideline against it) because the administrator might want to keep the logfile around from the uninstalled package, and it doesn't do anything for logfiles that have been rotated. I think that's it for now, I'd like someone more familiar with mono than myself to look this over too. The guidelines for mono packages can be found at https://fedoraproject.org/wiki/Packaging:Mono -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review