Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-DateTime-Format-Mail https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201477 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |pertusus@xxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From pertusus@xxxxxxx 2006-08-06 08:42 EST ------- A blocker: - For t/pod99.t missing BuildRequires: perl(File::Find::Rule) 4 remarks: - no need to mv LICENCE LICENSE it is the spec file that must be american english - in the man page there is a reference to t/invalid and t/sample_dates, so it may be relevant to package t/ in %doc - I have the habit to add a trailing / to directories in %files for example notes could be notes/ - it may be relevant to contact the upstream about version strings, and try to convince him to have version strings in ascii ascending order (relevant for other DateTime modules) Otherwise * rpmlint warning, may be ignored W: perl-DateTime-Format-Mail strange-permission filter-requires.sh 0755 * free software, licences included * meets packaging guidelines * spec legible * match upstream d3940d6b387b75de0332201db1685e7d ./DateTime-Format-Mail-0.30.tar.gz * sane provides: Provides: perl(DateTime::Format::Mail) = 0.30 * %files right If you fix (or explain) the BuildRequires I'll approve -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review