Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225852 --- Comment #1 from Debarshi Ray <debarshi.ray@xxxxxxxxx> 2008-12-28 12:05:45 EDT --- MUST Items: xx - rpmlint is unclean on RPM + [rishi@freebook devel]$ rpmlint gok gok.x86_64: W: file-not-utf8 /usr/share/doc/gok-1.3.7/NEWS gok.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/gok.schemas gok.x86_64: W: non-standard-group Desktop/Accessibility 1 packages and 0 specfiles checked; 0 errors, 3 warnings. [rishi@freebook devel]$ + rpmlint is unclean on SRPM [rishi@freebook SPECS]$ rpmlint /devel/rpmbuild/SRPMS/gok-2.25.2-1.fc9.src.rpm gok.src:251: W: macro-in-%changelog _lib gok.src: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 19) gok.src: W: non-standard-group Desktop/Accessibility 1 packages and 0 specfiles checked; 0 errors, 3 warnings. [rishi@freebook SPECS]$ OK - follows Naming Guidelines OK - spec file is named as %{name}.spec xx - package does not meet Packaging Guidelines + Please consider fixing the mixed use of tabs and spaces in the BuildRequires and Requires tags. + Even though Fedora does not use the Group tag, please consider using one from /usr/share/doc/rpm-4.4.2.3/GROUPS. "User Interface/Desktops" is a probable choice. Orca also uses it. + 'Requires: htmlview' is needed because of Patch0. + Can gok-1.2.1-fixlogin.patch be removed from CVS? + Please convert /usr/share/doc/gok-1.3.7/NEWS from ISO-8859 to UTF-8. See: https://fedoraproject.org/wiki/PackageMaintainers/Common_Rpmlint_Issues#file-not-utf8 + According to https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make you should use 'make %{?_smp_mflags}' whenever possible. In this case since upstream supports parallel builds you should use it. + To preserve timestamps you could consider using: make install INSTALL="%{__install} -p" DESTDIR=$RPM_BUILD_ROOT + 'rm -rf $RPM_BUILD_ROOT/var/scrollkeeper' is not needed on recent distributions. + Replace %{_lib} with %%{_lib} in the %changelog. OK - license meets Licensing Guidelines OK - license field meets actual license + gok/keysym2ucs.c is in the public domain. OK - upstream license file included in %doc OK - spec file uses American English OK - spec file is legible OK - sources match upstream sources xx - package does not build successfully + Fails to build due to missing BuildRequires: http://koji.fedoraproject.org/koji/taskinfo?taskID=1023579 OK - ExcludeArch not needed xx - build dependencies incorrectly listed + 'BuildRequires: esound-devel' is missing. + 'BuildRequires: m4 perl(XML::Parser)' is redundant. OK - locales handled properly OK - no shared libraries OK - package is not relocatable xx - file and directory ownership + Since an icon has been installed under %{_datadir}/icons/hicolor there should be a runtime dependency on hicolor-icon-theme. However, is this icon really needed as there is no .desktop file? + The -devel sub-package should have 'Requires: gtk-doc' as it needs /usr/share/gtk-doc. OK - no duplicates in %file OK - file permissions set properly OK - %clean present OK - macros used consistently + Both gok and %{name} used. OK - contains code and permissable content OK - -doc is not needed OK - contents of %doc does not affect the runtime OK - no header files OK - no static libraries OK - -devel has *.pc file and requires pkgconfig OK - no library files OK - -devel requires base package OK - no libtool archives OK - %{name}.desktop file not provided + Changelog contains rationale for excluding it. OK - does not own files or directories owned by other packages OK - buildroot correctly prepped OK - all file names valid UTF-8 SHOULD Items: OK - upstream provides license text xx - no translations for description and summary xx - package fails to build in mock + 'BuildRequires: esound-devel' is missing. OK - package builds on all supported architectures OK - package functions as expected xx - scriptlets are not sane + There does not seem to be any .omf files provided by the package, yet the scrollkeeper scriptlets are being used. Why? It looks like gok-1.3.7-3.fc9.x86_64 had them. OK - subpackages other than -devel are not needed OK - pkgconfig files in -devel OK - no file dependencies -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review