Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477990 Kevin Fenzi <kevin@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs? --- Comment #2 from Kevin Fenzi <kevin@xxxxxxxxx> 2008-12-27 20:47:37 EDT --- >1.) Please don't do --vendor ""; in case upstream specifies vendor field, do >not reset it, otherwise set it to "fedora" >https://fedoraproject.org/wiki/Packaging/Guidelines#.desktop_file_creation Good catch. Fixed to use fedora as vendor (upstream doesn't have one by default) >2.) Please ensure the following is correct: >Build Configuration: >* Installation prefix: /usr >* Debug Support: minimum >* Libnotify support: no >* Xcursor support: yes >* Sounds settings support no >* Libxklavier support: no >Did you really mean to build w/o support for the above? Nope. Thanks for spotting those. Added some buildrequires to pick them up. >3.) The following line seems useless: >find $RPM_BUILD_ROOT -name '*.desktop' -ls >I guest it was forgotten there. Please remove it. Well, it's needed because the make install installs the desktop files, and I then install them again with desktop-file-install. I can just use --delete-original instead. I will switch to that. >I don't think any of the above would warrant a review blocker: > >APPROVED Thanks! FYI, new package: Spec URL: http://www.scrye.com/~kevin/fedora/xfce4-settings/xfce4-settings.spec SRPM URL: http://www.scrye.com/~kevin/fedora/xfce4-settings/xfce4-settings-4.5.92-2.fc11.src.rpm CVS request: New Package CVS Request ======================= Package Name: xfce4-settings Short Description: Settings Manager for Xfce Owners: kevin Branches: devel InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review