Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477953 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx --- Comment #1 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2008-12-27 16:23:36 EDT --- Just some comments on your spec file - 'Source0:' should point to the upstream tarball if possible. - Please preserve the time stamp in the %install section - Shouldn't '%doc demo' be '%doc demo/' ? - Replace '/usr/bin/' with a macro https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Macros rpmlint is not quite... [fab@laptop024 SRPMS]$ rpmlint podcatcher-3.1.4-1.fc10.src.rpm podcatcher.src: E: no-cleaning-of-buildroot %install podcatcher.src: W: more-than-one-%changelog-section podcatcher.src: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 16) 1 packages and 0 specfiles checked; 1 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review