Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=455164 Kevin Fenzi <kevin@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #2 from Kevin Fenzi <kevin@xxxxxxxxx> 2008-12-27 15:18:37 EDT --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv2+) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 05a9a2a392bd3d6d44d1576e624ba74a NaturalDocs-1.4.zip 05a9a2a392bd3d6d44d1576e624ba74a NaturalDocs-1.4.zip.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version Issues: 1. It looks pretty clear that the package is GPLv2+, but some of the files just say "the GPL". You might ping upstream about that and suggest they mention that it's v2 or later. 2. Might use 'install -p' to preserve the timestamp on the script. 3. SourceUrl is not right... looks like they use naturaldocs instead of NaturalDocs in there. Ie: http://downloads.sourceforge.net/naturaldocs/%{name}-%{version}.zip None of those are blockers, so this package is APPROVED, provided you fix those up on import. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review