Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460600 Jan Kratochvil <jan.kratochvil@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jan.kratochvil@xxxxxxxxxx --- Comment #2 from Jan Kratochvil <jan.kratochvil@xxxxxxxxxx> 2008-12-23 13:47:11 EDT --- (In reply to comment #0) > This is my first package, and so I need a sponsor :-) Please check the list of sponsors as described on: http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored You may also want to mail <fedora-devel-list@xxxxxxxxxx>. With the .spec file I find there these issues: # Don't want the source rm -rf $RPM_BUILD_ROOT/usr/src (1) It has no effect as /usr/src/debug is created _after_ all the %install commands. (2) /usr/src/debug should be present for valid debuginfo package, I do not know why you would like to delete it at all. This argument has any effect? Could you make a comment there, please? MAKEINFO=`which makeinfo` IMO this your change was unnecessary, the single line does the some: -%{_prefix}/%{target} +%dir %{_prefix}/%{target} +%dir %{_prefix}/%{target}/lib +%dir %{_prefix}/%{target}/lib/ldscripts +%dir %{_prefix}/%{target}/bin + +%{_prefix}/%{target}/lib/ldscripts/* +%{_prefix}/%{target}/bin/* This is missing there: # these are for win targets only rm $RPM_BUILD_ROOT%{_mandir}/man1/%{target}-{dlltool,nlmconv,windres}.1 `rm' commands there miss `-f' which is IMO recommended in general. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review