Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tuxpuck - 3D Shufflepuck Pong Game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201153 ------- Additional Comments From wart@xxxxxxxxxx 2006-08-04 16:39 EST ------- GOOD ==== * rpmlint output clean * Package and spec file named appropriately * Spec file legible and in Am. English * GPL license ok, license file included * Source matches upstream: fc839abc2b1f3eafae397e1ed6487079 tuxpuck-0.8.2.tar.gz * Builds in mock on FC4, FC5, and FC6 for both i386 and x86_64 * Not relocatable * No locales * No shared libs * RPM_BUILD_ROOT cleaned where necessary * macro usage consistent * .desktop file installed correctly * no -devel package needed * no need for -doc subpackage * Does not own directories that it should not. * Package runs, but won't let me win. ;) MUSTFIX ======= * Remove the comment about 'doesn't build with optflags', since you are building it with %optflags * Add BR: desktop-file-utils, as mentioned in comment #1 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review