[Bug 200976] Review Request: cyphesis - WorldForge game server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cyphesis - WorldForge game server


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200976





------- Additional Comments From paul@xxxxxxxxxxxx  2006-08-04 06:26 EST -------
(In reply to comment #11)
> (In reply to comment #10)
> > rpmlint warnings - srpm
> > W: cyphesis macro-in-%changelog files
> 
> My bad.  I'll fix this in the next package.
> 
> > In the meantime, please refer back to report #9 and rebuild with the changes
> > recommended in there.
> 
> If I use the steps in comment #9 then I've essentially replaced a slightly messy
> looking %files section with an even messier scriptlet in %install.  I'm not so
> sure that it makes the spec file any more readable.  But I won't argue too much
> on this point.  If you prefer how the spec looks with the scriptlet from comment
> #9, then I'll use it.

If you only have three or fewer directories containing .py* files then it
doesn't really make sense to use the script-based approach as the files list is
quite clear. The script approach really has benefits for bigger packages like
moin and twisted, where there can be dozens of directories involved.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]