Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200664 ------- Additional Comments From paul@xxxxxxxxxxxxxxxxxxxxxx 2006-07-31 17:29 EST ------- Review Spec file : (based on my modifiction) Good - consistant use of macros, upstream md5 is the same as the tarball, no dupes in the BRs. rpmlint reports clean for all packages (does give no docs in -devel, this can be ignored, not an error). rpm -qa --requires comes up clean (nothing missing) Needs work/Niggle rm -rf $RPM_BUILD_ROOT%{_prefix}/doc/%{name} - why is this going to /usr/doc instead of %{_docdir}? Question sed -i 's|\r||' README.html COPYING.TXT - is this to remove the incorrect termination of the files? I tend to use 's/\r//' -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review