Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qstat - Real-time Game Server Status for Quake servers https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200374 ------- Additional Comments From wart@xxxxxxxxxx 2006-07-29 15:47 EST ------- GOOD ==== * rpmlint output clean * Package and spec file name named appropriately * Artistic license ok, license file included * File matches upstream: ac3ce3dbed5248bd5738a4968460880e qstat-2.10.tar.gz * Spec file legible and in Am. English * Builds and packages in mock on FC4, FC5, and FC5, both i386 and x86_64 * Package provides list is sane * No BR: necessary * No locales * No shared libs * Not relocatable * Does not create any directories that it should own * No duplicate %files * File permissions ok * build root cleaned in %install and %clean as necessary * Contains code, not content * No need for -doc or -devel subpackages * No .la files created * Not a gui app; no .desktop file needed MUSTFIX ======= * %doc contains some unnecessary files that should be removed: COMPILE.txt Makefile* template/Makefile* NOTES ===== * There are a number of compiler warnings about pointer signedness that appear harmless. If you feel inclined, you could report these upstream. qstat.c:2912: warning: pointer targets in passing argument 6 of 'recvfrom' differ in signedness -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review