Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ibmasm https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193059 ------- Additional Comments From paul@xxxxxxxxxxxxxxxxxxxxxx 2006-07-28 17:18 EST ------- rpmlint on the binary has shown problems which need addressing before you progress W no-soname /lib/libsysSP.so E shlib-with-non-pic-code /lib/libsysSp.so E shared-lib-without-dependency-information /lib/libsysSp.so E non-standard-executable-perm /usr/sbin/ibmspup 0744 E non-readable /usr/sbin/ibmsphalt 0700 E non-standard-executable-perm /usr/sbin/ibmsphalt 0700 W no-reload-entry /etc/rc.d/init.d/ibmasm E incoherent-subsys /etc/rc.d/init.d/ibmasm ibmsphalt Other notes You need to put a blocker on this for x86_64 and explain why You should be consistent on how you use $RPM_BUILD_ROOT - have everything as ${RPM_BUILD_ROOT} or $RPM_BUILD_ROOT (or better still, %{buildroot}) but not a mixture mkdir -p $RPM_BUILD_ROOT/usr/bin should be $RPM_BUILD_ROOT%{_sbindir} You don't seem to have added anywhere the runlevels this should run at The %doc can be on one line You need either to change the /sbin/ldconfig to read %post -p /sbin/ldconfig or add BR ldconfig Similarly, you need chkconfig adding as a BR As I said in #12, please remember to post the full URL of the updated SRPM and spec file. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review