[Bug 200472] Review Request: perl-POE-Component-SNMP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-POE-Component-SNMP


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200472


tibbs@xxxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs@xxxxxxxxxxx  2006-07-27 23:14 EST -------
Something's odd with the test suite:

t/10_snmp_get.........POE::Kernel's run() method was never called.
skipped
        all skipped: No SNMP data specified.

Looking deeper, all of the skipped tests require not only network access, but a
running SNMP server to talk to and write to that gets configured when
Makefile.PL is run.  So I guess everything's working as intended.

* source files match upstream:
   d13446b20b21e24c15fd6be406006bec  POE-Component-SNMP-1.05.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper (BR: perl is unnecessary)
* %clean is present.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane:
   perl(POE::Component::SNMP)
   perl(POE::Component::SNMP::Dispatcher) = 1.27
   perl(POE::Net::SNMP)
   perl-POE-Component-SNMP = 1.05-1.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(POE::Component::SNMP::Dispatcher)
   perl(POE::Kernel)
   perl(POE::Session)
   perl(Time::HiRes)
   perl(base)
   perl(constant)
* %check is present; the test suite doesn't seem to run well but what can run
passes:
   All tests successful, 10 tests skipped.
   Files=11, Tests=4,  2 wallclock secs ( 1.44 cusr +  0.50 csys =  1.94 CPU)

* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]