Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-POE-Component-Client-LDAP https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200152 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-07-27 21:08 EST ------- Not much to say here either; builds and installs fine and rpmlint is quiet. * source files match upstream: 5a52805b889af864622158d761b72f82 POE-Component-Client-LDAP-0.04.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text included in package. * latest version is being packaged. * BuildRequires are proper (BR: perl is unnecessary) * %clean is present. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane: perl(POE::Component::Client::LDAP) = 0.04 perl(POE::Filter::ASN1) = 0.01 perl-POE-Component-Client-LDAP = 0.04-1.fc6 = perl >= 0:5.006 perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Convert::ASN1) perl(Net::LDAP::ASN) perl(Net::LDAP::Constant) perl(POE) perl(base) perl(strict) perl(warnings) * %check is present and all tests (test?) pass: All tests successful. Files=1, Tests=1, 0 wallclock secs ( 0.14 cusr + 0.05 csys = 0.19 CPU) * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review