Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtkdatabox https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196529 ------- Additional Comments From cweyl@xxxxxxxxxxxxxxx 2006-07-27 00:59 EST ------- While the "no-docs" rpmlint warning is normally ignorable, given that there doesn't appear to be any other documentation available, please include examples/*.c in -devel under %doc. Also, given that there is a shared library in the system path in -devel, you need to put in place the %post/%postun scriptlets that are in place for the main package. + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. (LGPL) License text included in package. + source files match upstream: 847d59ea06ef92426b0911785a5f0c8c gtkdatabox-0.5.3.0.tar.gz 847d59ea06ef92426b0911785a5f0c8c gtkdatabox-0.5.3.0.tar.gz.srpm + latest version is being packaged. + BuildRequires are proper. + package builds in mock (x86_64: fc5 & devel). X rpmlint is silent + Final provides/requires are sane. ** gtkdatabox-0.5.3.0-1.fc5.x86_64.rpm == rpmlint == provides libgtkdatabox-0.5.3.so.0()(64bit) gtkdatabox = 0.5.3.0-1.fc5 == requires /sbin/ldconfig /sbin/ldconfig libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libcairo.so.2()(64bit) libdl.so.2()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) ** gtkdatabox-debuginfo-0.5.3.0-1.fc5.x86_64.rpm == rpmlint == provides libgtkdatabox-0.5.3.so.0.0.0.debug()(64bit) gtkdatabox-debuginfo = 0.5.3.0-1.fc5 == requires ** gtkdatabox-devel-0.5.3.0-1.fc5.x86_64.rpm == rpmlint W: gtkdatabox-devel no-documentation == provides gtkdatabox-devel = 0.5.3.0-1.fc5 == requires gtk2-devel gtkdatabox = 0.5.3.0-1.fc5 pkgconfig X shared libraries are present: proper %post/%postun in place for main package but not -devel. + package is not relocatable. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + %clean is present. O %check is not present; package has no tests suite X proper scriptlets present (%post/%postun for -devel). + code, not content. + documentation is (will be) small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers in main package. + no pkgconfig files in main package. + -devel properly requires main package. + no libtool .la droppings. + not a GUI app. + not a web app. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review