Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ip6sic - IPv6 Stack Integrity Checker https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198586 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-07-27 00:50 EST ------- My only concern is the description; I'm not sure it's really relevant to mention that the source will compile on OpenBSD, or to mention the isic URL when isic is already in extras. I'll leave it to you to decide what you want to do. Review: * source files match upstream: b545715256f9c362703754a894fe9093 ip6sic-0.1.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: ip6sic = 0.1-1.fc6 = libdnet >= 1.1.0 libdnet.so.1()(64bit) libpcap >= 0.4 libpcap.so.0.9.4()(64bit) * %check is not present; no test suite upstream. * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review