Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-POE-Component-Client-Keepalive https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198884 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-07-26 00:23 EST ------- The only thing I have to say about this is that the build sat around for about three minutes doing nothing, probably due to the test suite. Everything passed in the end so I don't see any problems. * source files match upstream: 79ea0242da708c7a8e190c00efdfccaf POE-Component-Client-Keepalive-0.0801.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper (BR: perl is unnecessary) * Compiler flags are appropriate (noarch package so none passed) * %clean is present. * package builds in mock (development, x86_64). * noarch package, so no debuginfo. * rpmlint is silent. * final provides and requires are sane: perl(POE::Component::Client::Keepalive) = 0.0801 perl(POE::Component::Connection::Keepalive) = 60 perl-POE-Component-Client-Keepalive = 0.0801-1.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Errno) perl(POE) perl(POE::Component::Client::DNS) perl(POE::Component::Connection::Keepalive) perl(POE::Wheel::ReadWrite) perl(POE::Wheel::SocketFactory) perl(bytes) perl(constant) perl(strict) perl(vars) perl(warnings) * %check is present and all tests pass: All tests successful. Files=15, Tests=88, 192 wallclock secs ( 2.58 cusr + 0.70 csys = 3.28 CPU) * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review