Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: SEC - Simple Event Correlator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169345 jpmahowald@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From jpmahowald@xxxxxxxxx 2006-07-25 23:37 EST ------- OK, release 4: rpmlint: W: sec non-conffile-in-etc /etc/sec/README W: sec non-conffile-in-etc /etc/sec/examples/pix-security.sec W: sec non-conffile-in-etc /etc/sec/examples/snortsam.sec W: sec non-conffile-in-etc /etc/sec/examples/syslog-ng.sec W: sec non-conffile-in-etc /etc/sec/examples/general.sec W: sec non-conffile-in-etc /etc/sec/examples/001_init.sec W: sec non-conffile-in-etc /etc/sec/examples/snort.sec W: sec non-conffile-in-etc /etc/sec/examples/pix-url.sec W: sec non-conffile-in-etc /etc/sec/examples/hp-openview.sec W: sec non-conffile-in-etc /etc/sec/examples/bsd-PHYSMOD.sec W: sec non-conffile-in-etc /etc/sec/examples/cvs.sec W: sec non-conffile-in-etc /etc/sec/examples/vtund.sec W: sec non-conffile-in-etc /etc/sec/examples/ssh.sec W: sec non-conffile-in-etc /etc/sec/examples/dameware.sec W: sec non-conffile-in-etc /etc/sec/examples/ssh-brute.sec W: sec non-conffile-in-etc /etc/sec/examples/clamav.sec W: sec non-conffile-in-etc /etc/sec/examples/labrea.sec W: sec non-conffile-in-etc /etc/sec/examples/mpd.sec W: sec non-conffile-in-etc /etc/sec/examples/bsd-MONITOR.sec W: sec non-conffile-in-etc /etc/sec/examples/bsd-USERACT.sec W: sec non-conffile-in-etc /etc/sec/examples/windows.sec W: sec non-conffile-in-etc /etc/sec/examples/dbi-example.sec W: sec non-conffile-in-etc /etc/sec/examples/amavisd.sec W: sec non-conffile-in-etc /etc/sec/examples/portscan.sec Non-executable files in your package are being installed in /etc, but is not marked %config. I'm inclined to ignore, they are samples. W: sec incoherent-subsys /etc/rc.d/init.d/sec $prog W: sec strange-permission sec.init 0755 W: sec mixed-use-of-spaces-and-tabs All minor. - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream * However, you could have the URL point directly to the source: http://dl.sourceforge.net/sourceforge/simple-evcorr/%{name}-%{version}.tar.gz - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review