Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Kmenu-gnome https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196003 ------- Additional Comments From rdieter@xxxxxxxxxxxx 2006-07-25 17:18 EST ------- * upstream source checks out: 9b36e22fc02f022e35fae3241ec9d622 31025-kmenu-gnome-0.6.tar.gz 1. missing %build section. Though this is mostly harmless... 2. drop the use of $RPM_BUILD_DIR. 3. rm -rf %{buildroot} should be at beginning of %install section, not %prep 4. scriptlets should (instead) be touch --no-create %{_datadir}/icons/Bluecurve ||: touch --no-create %{_datadir}/icons/crystalsvg ||: similarly, I'd recommend replacing %files %{_icondir}/*/*/*/* with %{_datadir}/icons/Bluecurve/*/*/* %{_datadir}/icons/crystalsvg/*/*/* 5. Due to ownership of stuff under %{_datadir}/icons/Bluecurve, to avoid possible unowned directory, you should Requires: redhat-artwork (yucky yes, but unowned dirs are even worse) 6. License. Should probably be License: GPL/LGPL since there are bits of both in this package. Fix (at least) 2-6, and I'll approve this. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review