[Bug 189662] Review Request: transconnect -- A function imposter to allow transparent connection over HTTPS proxies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: transconnect -- A function imposter to allow transparent connection over HTTPS proxies


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189662





------- Additional Comments From pertusus@xxxxxxx  2006-07-25 10:37 EST -------
(In reply to comment #5)
> * Tue Jul 25 2006 Enrico Scholz <enrico.scholz@xxxxxxxxxxxxxxxxxxxxxxxxx> -
1:1.3-0.3.Beta
> - removed the %(id -u) from the buildroot; it adds unneeded clutter,
>   is not required and you gain nothing with it

This issue should really be clarified. In the guidelines it is said
"The preferred value for the BuildRoot tag is"
so this looks like an almost must to me. I'll ask on the fedora-extras-list

> - fixed paths in 'tconn.cat'
> - enhanced 'README.fedora'

Ok.

> > This package have never been released, you don't need to increase
> > the epoch?
> 
> Needed as upgrade path on my systems; you want to follow the guidelines
> strictly and these guidelines do not forbid epoch...

I think it is better to follow the guidelines, because this is a case
where they make sense, since there may be a 1.3 and there is no reason
to make an exception for this package anyway. Adding an epoch is also 
bad.
I also understand your local issue, but I think we should avoid as
far as possible that local issue interfer with fedora extras packaging.
Isn't there another solution for your upgrade path, like setting 
a Provide temporarily in your local repo? Otherwise I guess this issue 
should be submitted to the fedora-extras-list, since it is likely to be 
a situation that will happen again in the future. 

> * I like it
> * it is used in all my other packages
> * it does not violate the guidelines

If you insist. But I think that it really complicates things
needlessly.

> 'tconn.so' will not be dlopen()'ed but LD_PRELOAD'ed. Placing into the
> searchpath allows
> 
> | LD_PRELOAD=tconn.so
> 
> without specifying the full path. Therefore, I will keep it in %_libdir.

Ok, makes sense.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]