Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: clement-2.1 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176253 ------- Additional Comments From j.w.r.degoede@xxxxxx 2006-07-25 07:27 EST ------- As promised here is a full review: MUST: ===== * rpmlint output is clean, good! * Package and spec file named appropriately * Packaged according to packaging guidelines * License (GPL) ok, license file included * spec file is legible and in Am. English. 0 Cannot verify if source matches upstream because of broken Source URL, this must be fixed! * Compiles and builds on devel-x86_64 * BR: ok * No locales * No shared libraries * Not relocatable 0 Package does NOT owns / or requires all dirs * No duplicate files & Permissions ok * %clean & macro usage OK * Contains code and permissible content * %doc does not affect runtime, and isn't large enough to warrent a sub package * no -devel package needed, no libs / .la files. * no gui -> no .desktop file required MUST fix: ========= * Proper downloadable Source URL * This is dead wrong: %attr(-,mail,mail) %{_usr}/share/%{name}-%{version}/logs/ Running software cannot shall not and must not write to /usr it could be on a readonly partition or or or .... Please make that: %attr(-,mail,mail) %{_var}/log%{name}-%{version}/ And adjust the software to write it logs there, or am I misinterpreting the dir name here? * Unowned dir %{_usr}/share/%{name}-%{version} Add: "%dir %{_usr}/share/%{name}-%{version}" to %files or better replace: %{_usr}/share/%{name}-%{version}/*.php %{_usr}/share/%{name}-%{version}/reg-icons %{_usr}/share/%{name}-%{version}/local %{_usr}/share/%{name}-%{version}/cgi-bin With just: %{_usr}/share/%{name}-%{version} Should fix: =========== * Spec contains: "#%postun" this will end up as the last line of the %preun line, harmless but it it would be cleaner to just remove it completly. * Replace all occurences of "%{_usr}/share" with "%{_datadir} So all in all its looking good! Once all the must fix items are taken care of I'll sponsor you and you can import this. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review