Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libpano12 : Library and tools for manipulating panoramic images https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200064 ------- Additional Comments From bruno@xxxxxxxxxx 2006-07-25 06:19 EST ------- (In reply to comment #3) I've updated the files: Spec URL: http://bugbear.blackfish.org.uk/~bruno/apt/SPECS/libpano12.spec SRPM URL: http://bugbear.blackfish.org.uk/~bruno/apt/fedora/linux/5/x86_64/SRPMS.panorama/libpano12-2.8.4-3.src.rpm > %define name_version %{name}-%{version} > > This isn't needed. Just wipe it > BR gcc isn't needed Ok gone. > Not sure on the obsoletes/provides. This was for users migrating from rh9 to fc1, I guess it isn't needed any more ;-) > %configure --prefix - %configure is enough (unless the tarball decides to put it > somewhere odd). If it is available as a configure option, include --disable-static Ok done. --disable-static is an option, but I still have to rm the .la file > the two strip lines aren't required. Ok done. > %package devel > > Requires : should be %{version}-%{release}. It helps keep the devel files in > pace with the main package. > > %description devel > > The second paragraph isn't needed Fixed. > %files > > %{_bindir}/* - how many binaries does the package make? If they all start with > PT, then %{_bindir}/PT* and then one for the other one is a much better idea. > The same applies with the %{_libdir} Ok I've changed them to be more specific. > Does libpano12 not create it's own directory in %{_includedir} or is it again > just a couple of files? Yes it creates %{_includedir}/pano12. Fixed -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review