Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xdg-utils - Basic desktop integration functions https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199968 ------- Additional Comments From devrim@xxxxxxxxxxxxxxxxx 2006-07-24 17:38 EST ------- Hi, Here a review. Please note that this is not an official review; because I'm not yet sponsored. MUST items: * rpmlint check -- rpmlint gives a warning on srpm. You'll need to fix it: W: xdg-utils mixed-use-of-spaces-and-tabs The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. * Per Naming Guidelines, you should rename the spec to xdg-utils.spec * dist tag is not present. You must add it. * The package is named according to the Package Naming Guidelines. * The package is licensed with an open-source compatible license GPL. * This package includes License file LICENSE. * The sources used to build the package matches the upstream source, as provided in the spec URL. md5sum is correct fde4bf35fc34c58faa562bfb96103eb5. * This package successfully compiled and built into binary rpms for i386 architecture. * This package did not containd any ExcludeArch. * This package owns all directories that it creates. * This package did not contain any duplicate files in the %files listing. * Please use %{name} macro in Source0, and possibly in more places. * You must use make %{?smp_flags} instead of make in %build part. * This package have a %clean section, which contains rm -rf $RPM_BUILD_ROOT * Doc files are present: ChangeLog LICENSE README TODO * Package is not relocatable. * The permissions of installed files look correct. * There are no .la libtool archives in the package. * Source URL is correct. * BuildRoot line meets guidelines. Also, I think you should clean up the spec -- it looks messy. Regards, Devrim -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review