Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xmms-musepack - Mpegplus (mpc) playback plugin for XMMS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188461 ------- Additional Comments From pertusus@xxxxxxx 2006-07-24 17:11 EST ------- Still not right: - gcc-c++ should be omitted from buildrequires - %setup -q - buildroot is wrong In the %changelog, the lines are like * Wed May 3 2006 Matthias Saou <http://freshrpms.net/> 1.2-2.1 the strange thing in it is <http://freshrpms.net/> instead of a mail adress. Is it acceptable? * rpmlint gives W: xmms-musepack setup-not-quiet * follow naming and packaging guidelines * licence is BSD-like, included * spec legible * source match upstream ff7f5f9122d09ad63af9c564046086cf xmms-musepack-1.2.tar.bz2 * builds and works on devel * use macros consistently * don't own any directory * %files section right * no missing BuildRequires * only dlopened library, in the right directory for xmms If the above issues are solved I would approve that package -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review