Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: transconnect -- A function imposter to allow transparent connection over HTTPS proxies https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189662 ------- Additional Comments From pertusus@xxxxxxx 2006-07-24 04:22 EST ------- (In reply to comment #2) > - follow Fedora naming guidelines strictly; increased epoch This package have never been released, you don't need to increase the epoch? > ==== > no; I like it this way Indeed, but if I'm not wrong %{!?release_func:%global release_func() %1%{?dist}} Release: %release_func 0.2.Beta leads to the much simpler Release: 0.2.Beta%{?dist} so why not use the simpler way? Of course you could have set release_func() somewhere, but this flexibility is not usefull in fedora extras, yet it adds some complexity to the spec file. Otherwise, I have some other comments: * I think it would be nice if you dropped a line somewhere (in README.fedora?) explaining that tconn-localres.so corresponds with the make localres case described in the INSTALL file, or something along those lines. * I also think that the file tconn.cat could be modified such that export LD_PRELOAD=$HOME/.tconn/tconn.so is replaced by export LD_PRELOAD=%{_libdir}/tconn.so * I know that some reviewer disagree on having modules to be dlopened directly in %_libdir and insist on having dlopened modules in subdirs of %_libdir. I tend to agree with that when the modules are 'internal modules' or backends to be used by an application or a library. The transconnect case is less clear in my opinion, however I still think that it would be cleaner if the *.so where in a %_libdir subdir, say %{_libdir}/transconnect this would imply some adjustments in the tconn script, and in tconn.cat there should then be export LD_PRELOAD=%{_libdir}/transconnect/tconn.so What do you think about that? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review