Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kooldock - dock for KDE with great visual effects and enhancements https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199627 ------- Additional Comments From devrim@xxxxxxxxxxxxxxxxx 2006-07-23 16:09 EST ------- A few more comments: * I think you should change Source0 to use %{name} instead of kooldock. * The same is valid for the line beginning with %setup * You should use cvs_date macro in Source0 * You should add %{?smp_flags} to make in %prep That is all I can see now. Per Review Guidelines, I tried to test everything except mock build. Regards, Devrim -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review