Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: psycopg2 - A PostgreSQL database adapter for Python https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199784 ------- Additional Comments From mr.ecik@xxxxxxxxx 2006-07-22 06:57 EST ------- You changed name of package, but you forgot to change name in subpackage doc. It is nice to use macros in it: Requires: %{name} = %{version}-%{release} Next thing of the doc subpackage is its group. According to Packaging Guidelines the Group name of doc subpackage should be Documentation, not Applications/Databases. >From the main package you can delete python dependency, because rpm automatically adds it (I forgot about it, yesterday). The last thing is about doc subpackage again. I think it should be noarch, but then package won't compile well. Maybe, someone more experienced in reviewing would give you a good advice. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review