Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-POE-Component-IRC https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198882 ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-07-21 22:51 EST ------- I think the point is that you can't specify --with arguments when doing testing from within a normal CVS checkout with "make build" or "make mockbuild". Which indeed seems to be correct, but not really something that troubles me. It should be possible to add a bit to the Makefile to have "make build" pass the flags to rpm; doing it in mock seems to be right out. Chris's solution allows you to edit your .rpmmacros to set the flags and still use "make build". Seems reasonably unsavory to me as well, especially since it broke my build. I'd be surprised if it makes it through the buildsystem. I realize I wasn't very clear at all when I reviewed the package; my intention was to ensure that you removed that bit or came up with an alternate that would actually work in mock before you checked it in. As it is, I don't think the package will make it through the buildsys. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review