Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: psycopg2 - A PostgreSQL database adapter for Python https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199784 ------- Additional Comments From mr.ecik@xxxxxxxxx 2006-07-21 19:30 EST ------- I'm not experienced in reviewing packages and I'm not official reviewer, but first thing that came to my head is that you don't need to specify python version in release number. Packaging Naming Guidelines doesn't say anything about that. Also, python version will be assigned to package by python dependency. More important thing is wrong name of package. According to Package Naming Guidelines package' name should be python-psycopg2. Take a look on it: http://fedoraproject.org/wiki/Packaging/NamingGuidelines And the last thing: mock builds fail. It looks like adding dos2unix BuildRequires fixes this problem. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review