Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dstat https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199780 toshio@xxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |toshio@xxxxxxxxxxxxxxx ------- Additional Comments From toshio@xxxxxxxxxxxxxxx 2006-07-21 18:00 EST ------- Okay. To start, a few links: [1]_ General Guidelines the package must follow: http://www.fedoraproject.org/wiki/Packaging/Guidelines [2]_ Python Specific Packaging Hints: http://www.fedoraproject.org/wiki/Packaging/Python [3]_ Fedora Extras CVS. Look for examples of how other people do things here: http://cvs.fedora.redhat.com/viewcvs/rpms/?root=extras Some python applications you can look through there are qa-assistant, rpmlint, and gramps. The first thing that leaps out at me when I look at the spec is that the python files aren't bytecompiled. In addition to installing, you want to generate the .pyc and .pyo byte compiled files and install them. That way the package will know that it needs to remove the files as well. [1] and [3] should help you get through that. Looking over a spec or two from [3] and comparing to your rpm would be another good thing to do. (And now you can jump back on IRC and ask specific questions and we'll be better able to help ;-) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review