Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: oooqs2 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191389 michael@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |michael@xxxxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From michael@xxxxxxxxxxx 2006-07-21 05:06 EST ------- Hey.. I will review this package.. ---------------------------------------- Review for release 1: * RPM name is OK * Source oooqs2-1.0.tar.gz is the same as upstream * Builds fine in mock * File list looks OK Needs work: * BuildRequires: desktop-file-utils is missing * rpmlint: need to fix symlink warnings * The package should contain the text of the license (wiki: Packaging/ReviewGuidelines) * Scriptlets: missing "gtk-update-icon-cache" in %post (wiki: ScriptletSnippets) * Scriptlets: missing "gtk-update-icon-cache" in %postun (wiki: ScriptletSnippets) Notes: You fix up the %post/%postun scriplets, the is a COPYING file and it should be included in the %docs rpmlint of oooqs2: W: oooqs2 dangling-symlink /usr/share/doc/HTML/de/oooqs2/common /usr/share/doc/HTML/de/common W: oooqs2 symlink-should-be-relative /usr/share/doc/HTML/de/oooqs2/common /usr/share/doc/HTML/de/common W: oooqs2 dangling-symlink /usr/share/doc/HTML/en/oooqs2/common /usr/share/doc/HTML/en/common W: oooqs2 symlink-should-be-relative /usr/share/doc/HTML/en/oooqs2/common /usr/share/doc/HTML/en/common -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review