Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: PyKDE: Python bindings for KDE https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190367 michael@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |michael@xxxxxxxxxxx ------- Additional Comments From michael@xxxxxxxxxxx 2006-07-20 22:48 EST ------- Seeing how this has been sitting for a bit, I will do the review. Review for release 0.4.20060422: * Source PyKDE-snapshot20060422.tar.gz is the same as upstream * This is the latest version * Builds fine in mock * rpmlint of PyKDE-devel looks OK * rpmlint of PyKDE looks OK * File list of PyKDE-devel looks OK * File list of PyKDE looks OK Needs work: * Package does not follow Fedora's package naming guildlines (wiki: PackageNamingGuidelines) I am not certain, but the package naming guidelines talk about the use of cvs in the snapshot version. I noticed this is an upstream snapshot, so I am not sure if this applies. * The package should contain the text of the license (wiki: Packaging/ReviewGuidelines) There is a COPYING in the tarball, it should be added to the %docs This package is also GPL not MIT. Minor: * Duplicate BuildRequires: python-devel (by sip-devel), sip-devel (by PyQt-devel) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review