Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mysql-connector-java - Official JDBC driver for MySQL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193897 ------- Additional Comments From ifoox@xxxxxxxxxx 2006-07-20 15:16 EST ------- Hi Anthony, Thanks for the feedback, here are the new files: http://people.redhat.com/ifoox/extras/mysql-connector-java.spec http://people.redhat.com/ifoox/extras/mysql-connector-java-3.1.12-1jpp_2fc.src.rpm (In reply to comment #2) > rpmlint output is: > W: mysql-connector-java non-standard-group Development/Libraries/Java > > We just use Development/Libraries in Fedora. Perhaps there's an argument to be > made for Development/Libraries/Java, but let's use the standard for now. I'll > send a note to fedora-devel I've changed it to Development/Libraries. > > W: mysql-connector-java wrong-file-end-of-line-encoding > /usr/share/doc/mysql-connector-java-3.1.12/docs/README.txt > W: mysql-connector-java wrong-file-end-of-line-encoding > /usr/share/doc/mysql-connector-java-3.1.12/README.txt > W: mysql-connector-java wrong-file-end-of-line-encoding > /usr/share/doc/mysql-connector-java-3.1.12/EXCEPTIONS-CONNECTOR-J > > Fix these with sed in the %prep section like so: > %{__sed} -i 's/\r//' README.txt Done. > The spec file includes: > # remove all binary libs > find . \( -name "*.jar" -o -name "*.class" \) | xargs -t rm -f > > I would rather that we strip the .jar files from the tarball prior to packaging. > This will ensure that we don't accidentally ship binaries sans sources or > binaries with unfriendly licensing - even if they only show up in the SRPM. I feel kind of uncomfortable with doing this before pacakging, because it will defeat the point of the pristine upstream source. I don't see how doing this before the packaging process is better than doing it at %prep time, I'd say it's less reproducable. > Can you explain this part of the spec file?.. > Provides: mm.mysql > Obsoletes: mm.mysql Hmm, no I don't know why these are there. This package is taken from JPackage, I'll try contacting the packager and ask if there is a reason for these to remain. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review