Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199183 mr.ecik@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mr.ecik@xxxxxxxxx ------- Additional Comments From mr.ecik@xxxxxxxxx 2006-07-18 06:13 EST ------- Hi! I'm not yet sponsored so this is not official review. * MUST items: - rpmlint doesn't show anything - package is named according to Packaging Naming Guidelines - the spec file name is correct - package meets Packaging Guidelines - package is licensed with an open-source license - GPL, license field match actual license and package contains file with text of license in %doc - spec file is written in American English and is legible - package successfully compile on i386 - package doesn't contain duplicate files in %files section - %files section includes %defattr(...) line - spec file contains proper %clean section - macros is used proper in spec file and all others 'must' doesn't concern this package. I think you don't need CPPFLAGS="-Wall -Werror" in %build section, because the build server has his own CPPFLAGS (I think so) and could you explain what %%check section exaclty does? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review